nowinandroid
nowinandroid copied to clipboard
Fixes #341 Defines enter & exit animations for OverlayLoadingWheel on…
… ForYouScreen
Also added fadeOut because just animating it all the way up off the screen makes it ugly.
https://user-images.githubusercontent.com/1853043/197698785-76ff7eff-40ac-4b7a-9b2c-9b3a23f21d62.mov
@dturner would you please have a look? It's quite straight forward
Oh this is quite nice, lemme run it by the design team.
This is cool, thanks for submitting!
It seems the animations are causing the tests to have StackOverflowException when trying to assert that the progress bar is visible
Will do 👍
On Thu, 17 Nov 2022, 21:24 Milosz Moczkowski, @.***> wrote:
@.**** requested changes on this pull request.
Thank you for your contribution Yuri! Could fix the spotless check please?
— Reply to this email directly, view it on GitHub https://github.com/android/nowinandroid/pull/358#pullrequestreview-1184037737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOEM4ZAYXA6G6CHLS3TXBLWIYBWVANCNFSM6AAAAAARNULO7I . You are receiving this because you authored the thread.Message ID: @.***>
@mmoczkowski I've rebased on the main and pushed changes, back to square one with stack overflow during instrumentation test. Running tests locally on emulator on M1 works fine, application works fine. I'll have deeper look to find a root cause soon. Open for any suggestions
@mmoczkowski I've rebased on the main and pushed changes, back to square one with stack overflow during instrumentation test. Running tests locally on emulator on M1 works fine, application works fine. I'll have deeper look to find a root cause soon. Open for any suggestions
@YuraLaguta I restarted CI and all the tests passed 😄