nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

adding NiaApp layout preview

Open diverdan92 opened this issue 3 years ago • 3 comments

Made it so that the NiaApp Composable shows a full layout preview that mimics the first app layout that a user will see when launching the app (the topics screen). Also added reference device multi preview that matches reference devices elsewhere in Studio (Layout Editor, Layout Validation, etc...)

diverdan92 avatar Oct 14 '22 18:10 diverdan92

@diverdan92 Please could you fix the build issue (try adding the :core:domain repository), and the merge conflicts.

dturner avatar Nov 11 '22 18:11 dturner

Closing due to inactivity. If you still want to merge this change, please create a new PR

mmoczkowski avatar Nov 17 '22 10:11 mmoczkowski

I'm reopening this because it's pretty important that previewing the app works correctly, especially on large screens.

dturner avatar Nov 21 '22 16:11 dturner

A change was just merged to navigation where this should work without needing the LocalInspectionMode changes on our side: https://android-review.googlesource.com/2423106.

Once we've updated to a version with that change, adding previews should work directly.

alexvanyo avatar Feb 10 '23 18:02 alexvanyo

@alexvanyo has the version been updated already?

mmoczkowski avatar Mar 30 '23 09:03 mmoczkowski

Not yet, looks like we're on 2.5.3 still, and this was first released in 2.6.0-alpha06

alexvanyo avatar Mar 30 '23 15:03 alexvanyo

Closing this PR since this change won't be required after nav library update.

mmoczkowski avatar Aug 23 '23 13:08 mmoczkowski