nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Icons alignment to use NiaIcons

Open Abhimanyu14 opened this issue 3 years ago • 1 comments

Changes

  1. Changed icons used to use Nia Design System defined icons.
  2. Replaced ArrowBack from Rounded to Filled variant as Rounded was not used, but Filled was.

Abhimanyu14 avatar Jul 16 '22 17:07 Abhimanyu14

Hi, The android tests are passing locally, but failing in CI. Can anyone please help me understand how to fix it?

Abhimanyu14 avatar Aug 01 '22 18:08 Abhimanyu14

Please could you fix the merge conflicts.

dturner avatar Nov 11 '22 17:11 dturner

@dturner Done.

Abhimanyu14 avatar Nov 11 '22 17:11 Abhimanyu14

com.google.samples.apps.nowinandroid.ui.NavigationTest > homeDestination_back_quitsApp[test(AVD) - 6.0] FAILED java.lang.Exception: Unexpected exception, expected<androidx.test.espresso.NoActivityResumedException> but was<androidx.test.espresso.base.RootViewPicker$RootViewWithoutFocusException>

@dturner Flakiness? I've seen this on other builds as well

mmoczkowski avatar Nov 15 '22 11:11 mmoczkowski

Thank you for your contribution!

mmoczkowski avatar Nov 17 '22 12:11 mmoczkowski