codelab-kotlin-coroutines icon indicating copy to clipboard operation
codelab-kotlin-coroutines copied to clipboard

Error in the documentation explaining the use of `combine`.

Open TedHopp opened this issue 5 years ago • 2 comments
trafficstars

In step 11 of the advanced coroutines codelab, there's this sentence:

That means that while Room starts the network request, Retrofit can start the network query.

This seems wrong (Room doesn't do network requests). My guess is that it should read:

That means that while Room starts the database request, Retrofit can start the network query.

TedHopp avatar Oct 28 '20 04:10 TedHopp

This would be better still:

This means that while Room starts the database query, Retrofit can start the network request

KiranKandola avatar Jan 20 '21 18:01 KiranKandola

Better yet would be if they actually included an actual bloody Retrofit call in ANY of their examples - as this is the main use case people will have.

WeStartThen avatar May 10 '21 21:05 WeStartThen