architecture-samples icon indicating copy to clipboard operation
architecture-samples copied to clipboard

Published 20 hours ago • verified publisher icon android

Pull to refresh doesn't work when there are no tasks

Open AnirudhPudari opened this issue 2 years ago • 2 comments

Why these changes are required ?

Issue link

  • Currently on the task list screen when the content is empty or no tasks, pull to refresh doesn't work(it is not shown at all after you swipe down vertically)
  • Reason is the empty container shown doesn't contain pull to refresh
  • Exisiting SwipeRefresh is deprecated

What changes are addressed ?

  • Addressed the issue of showing a pull to refresh spinner both when the content is empty and not empty
  • Migrated SwipeRefresh to PullRefreshIndicator as suggested

todo_test.webm

AnirudhPudari avatar Mar 27 '23 15:03 AnirudhPudari

Please fix the spotless formatting.

dturner avatar Jun 05 '23 15:06 dturner

Please fix the spotless formatting.

@dturner Hi, I have addressed the issue, Please review PR. Thank you

AnirudhPudari avatar Jun 23 '23 04:06 AnirudhPudari