architecture-samples icon indicating copy to clipboard operation
architecture-samples copied to clipboard

First commit

Open aceiro opened this issue 5 years ago • 2 comments

Hi @JoseAlcerreca

I did some changes in branch dagger-android and I would like to know if it is possible contribute for your project. The main changes that I did were:

  • Added Retrofit compatibility using a public API - Placeholder
  • Added feature-flag to be used in compile variant - in this case, we can choice in Retrofit API and yours local and remote repository that you done
  • Added one item for task_fragment_menu.xml

So, let me know it like this changes. If was possible I can merge for other branch - based on dagger-android.

Have a nice day !

aceiro avatar Apr 11 '20 18:04 aceiro

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 11 '20 18:04 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Apr 11 '20 19:04 googlebot