architecture-samples
architecture-samples copied to clipboard
First commit
Hi @JoseAlcerreca
I did some changes in branch dagger-android and I would like to know if it is possible contribute for your project. The main changes that I did were:
- Added Retrofit compatibility using a public API - Placeholder
- Added feature-flag to be used in compile variant - in this case, we can choice in Retrofit API and yours local and remote repository that you done
- Added one item for
task_fragment_menu.xml
So, let me know it like this changes. If was possible I can merge for other branch - based on dagger-android.
Have a nice day !
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.