architecture-components-samples icon indicating copy to clipboard operation
architecture-components-samples copied to clipboard

Implement navigation tests and safe args

Open PavloRatushnyi opened this issue 7 years ago • 4 comments

PavloRatushnyi avatar Aug 03 '18 17:08 PavloRatushnyi

I don't think a UI test should know about the implementation details of the navigation so I wouldn't test using a listener.

JoseAlcerreca avatar Aug 08 '18 08:08 JoseAlcerreca

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot avatar Sep 02 '18 18:09 googlebot

CLAs look good, thanks!

googlebot avatar Sep 02 '18 18:09 googlebot

I've changed tests. Could you please look through this PR again?

PavloRatushnyi avatar Sep 02 '18 18:09 PavloRatushnyi