architecture-components-samples icon indicating copy to clipboard operation
architecture-components-samples copied to clipboard

Added size check control

Open rifatdover opened this issue 8 years ago • 6 comments

On replace update null check done but did not chek if the new size equals to 0.

rifatdover avatar Sep 26 '17 19:09 rifatdover

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Sep 26 '17 19:09 googlebot

I signed it!

rifatdover avatar Sep 26 '17 19:09 rifatdover

CLAs look good, thanks!

googlebot avatar Sep 26 '17 19:09 googlebot

@yigit Can you check this?

rifatdover avatar Oct 22 '17 14:10 rifatdover

I guess you intiate the adapter with data after creating it. So, what if you got no data from the api, or want to clear the recycler?

amrro avatar Oct 23 '17 02:10 amrro

Forgive me if I have a lack of knowledge but I can not understand the relation between your question and the thing I do? What is made inside adapter is passing an update data to the adapter. If api or JsonMapping creates an object list with 0 items adapter will cause crash. And if we come to your question I will pass null or an object with 0 items and it will work. @amrro

rifatdover avatar Oct 23 '17 07:10 rifatdover