react-css-components icon indicating copy to clipboard operation
react-css-components copied to clipboard

extraClassName

Open aymericbouzy opened this issue 8 years ago • 3 comments

Before I write tests for it, is this the way you envisioned it?

aymericbouzy avatar Mar 16 '17 10:03 aymericbouzy

Looks good, but the tests are failing. I think at this point we might need to migrate to Jest test runner and use its snapshot testing functionality so updating snapshots can be done automatically.

andreypopp avatar Mar 16 '17 11:03 andreypopp

Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass.

aymericbouzy avatar Mar 16 '17 12:03 aymericbouzy

You can just update the tests. On Thu, 16 Mar 2017 at 15:07 Aymeric Bouzy [email protected] wrote:

Migrating to Jest test runner is a different PR IMO. Would you like to do it now? Or I can update the tests to make them pass.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/andreypopp/react-css-components/pull/19#issuecomment-287037873, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB3glSoXrElPAxRxwlzf7KBgVn4iAnfks5rmSYZgaJpZM4MfG_x .

andreypopp avatar Mar 16 '17 12:03 andreypopp