chrome-remote-interface icon indicating copy to clipboard operation
chrome-remote-interface copied to clipboard

Use correct HTTP method for new page endpoint

Open tomassurin opened this issue 2 years ago • 1 comments

This PR fixes an incompatibility with recent chromium versions (111+)

Details

The main culprit is the API for creating pages = PUT /json/new. This library uses wrong HTTP method GET here. This got unnoticed up until now because chromium did not enforce the correct method. However, this changed recently where chromium started enforcing it and responding with an error:

Using unsafe HTTP verb GET to invoke /json/new. This action supports only PUT verb.

For context, this has been introduced by this chromium PR: https://chromium-review.googlesource.com/c/chromium/src/+/4110715

tomassurin avatar Mar 14 '23 16:03 tomassurin

lol, I checked the issues but not the PR, and recoded this one too :rofl: (#39)

@andrewvy , any chance to get this one merged and released?

Thanks!

gorghoa avatar Jan 18 '24 13:01 gorghoa