Andrew Tavis McAllister
Andrew Tavis McAllister
Let me know if there's anything I can do to help :) I'll also send along a commit to this that will make a check to see if the keys...
I guess one PR would be easier as that would allow me to plan around it, bring in some others, and then merge it all at once and not need...
Glad to have you working on this, @jennethydyrova! Looks like the styleguide needs to be updated as well. Let's use underscores for the whole thing. That was a poor choice...
Thank you, @jennethydyrova!
Closed by #948 🚀 Lots of work to get through this, @jennethydyrova, but with the new workflow we won't have to worry about naming keys anymore except for an identifier...
Good catch, @jennethydyrova :) That's likely just a placeholder, but definitely should be removed at some point. Do you want to do a quick PR to fix it?
Hmmm, good question :) Let's actually add it in. So this key's only in `CardSearchResult`, so based on the naming conventions we should change the instances of `components.meta-tag-video.view-video` to `components.card_search_result.view_video`,...
Thanks for this, @studiosi! I'll try to get to the review soon :) One thing, it looks like your email's not set up correctly based on our [first time contributor...
Closing as #1371 works towards maintaining user sessions :) Thanks for the efforts!
Closed by #476 🙌 So happy to have this done so we can use it for other menu options, @Jag-Marcel! 🚀