Andrew Tavis McAllister
Andrew Tavis McAllister
Hey @aasimsyed 👋 One thing I'm noting here is that it seems like you changed your Git email recently and haven't added it to your GitHub account as the commits...
Hey @aasimsyed 👋 Quick check in to see if we can get the changes finalized before Saturday so that we can hopefully merge these PRs in during the sync? Would...
Yes you do :) I think I'll try to squash the changes and remove the "other you" as a contributor, which should work 😊 Do you want to maybe send...
Things to consider based on discussions in the sync: - We'd ideally remove `rules.tsv` as they appear to also be in the YAML file - We'd want to make sure...
Ok @aasimsyed: Most recent commit sends the changes I was working on 😊 Would be great if you could check what were discussed and logged [here](https://github.com/activist-org/activist/pull/1232#issuecomment-2848732992)!
Are we ready for a final review here, @aasimsyed? :)
Looks like all the PRs aren't linked to your account, @aasimsyed 🤔 Do you want to follow the steps I mentioned in #1232 and then maybe you can do another...
And can you help with the review here, @cquinn540? 😊
And @cquinn540 and @aasimsyed: Do you two want to maybe do a call in the coming days to do the reviews for all of @aasimsyed's PRs :)
Would be great if we could spend some time during the sync to bring all of these in, @cquinn540 and @aasimsyed :) Hope you both can make it!