Andrew Tavis McAllister comments

Results 1097 comments of


                                            Andrew Tavis McAllister

feat: addition of signal social media

Hey @UnknownSean8 👋 So all's working well, but I do agree that we want to split the functionality of copying the link and the opening Signal. The copy link shouldn't...

feat: addition of signal social media

Also, don't worry about how some of the texts are a bit weird at the moment! This is coming from needing to combine a bunch of strings for the rework...

Add missing tests for files with low coverage

Sure thing, @meerhaasham1! How about you look into writing tests for [process_unicode.py](https://github.com/scribe-org/Scribe-Data/blob/main/src/scribe_data/unicode/process_unicode.py)? You'd add a `unicode` directory to the `tests` directory and then you can add a file `test_process_unicode.py` with...

Add missing tests for files with low coverage

Sounds great, @meerhaasham1! 🚀

Add missing tests for files with low coverage

I'm going to close this issue as there have been enough changes that we should open another one :) Thanks much, @axif0 and @haasham1! 😊

Update pr_ci.yaml

Yes I think this makes sense. So we need to set a specific version of GRDB :)

Update pr_ci.yaml

Thanks for the support here, @fabulouiOS-monk!

Update pr_ci.yaml

I think we can safely update and ask that the community does so. I'm not aware of anyone who would have a problem with this.

Update pr_ci.yaml

Thanks so much for the response here, @groue! As always so appreciative of and impressed by your support to the GRDB community. Maybe the thing to do here is upgrade...

Update pr_ci.yaml

Closing this one down as the changes here are not needed. GRDB was set to 6.0..