Andrew Leech

Results 441 comments of Andrew Leech

> I write the review about your Pull request last week. I ask you for an answer and code fix for this. Sorry I can't see any review comments on...

> Might be interesting to investigate FrogFS: https://github.com/jkent/frogfs First glance does look pretty good, a few nice features like compression / obfuscation. Already has tooling for building the filesystem separate...

@dpgeorge This has been rebased and integrated into the other recent changes in `re` ( 64193c7d ).

Yeah I was a bit shocked! Technically there's two changes here; support for `\x00` in the search data, and the buffer support. I'm planning to check the relative size of...

Ok so trimming it to just the null char change gives me a local diff of ``` bare-arm: +0 +0.000% minimal x86: +0 +0.000% unix x64: +240 +0.030% standard stm32:...

> +1 for a real implementation of this The cpython implementation is surprisingly _very_ complicated and relies heavily on metaclasses which aren't supported in micropython: https://github.com/python/cpython/blob/f585ed19ad00f78ed99ba44be5e333c056076160/Lib/enum.py#L1051 As such any micropython...

> ```python > class State(int): > pass > > State.OFF = State(0) > State.ON = State(1) > > ``` > > But when have been imported getting "Unresolved attribute reference"...

Umm... there's been 14 commits merged in the last 3 weeks. That's not nothing/ever. Sure, more is better, but quality over quantity is also key. Most of the pr's here...