libproc-rs

libproc-rs copied to clipboard

Improve the docs

1

Improve overall docs - I need to learn how to properly document modules, structs, traits and functions in rust following the bets guidelines. A couple of functions need descriptions or...

andrewdavidmackenzie

Add own error types? use io::Result subtype? stay with Strings?

andrewdavidmackenzie

As mentioned in https://github.com/andrewdavidmackenzie/libproc-rs/pull/22 I don't really like how the external API looks - but I still need to learn rust best practices here. So, sorry if ugly in the...

andrewdavidmackenzie

Should be able to take clippy out of the matrix

andrewdavidmackenzie

build error in aosp rust

1

error 1: ```bash error[E0425]: cannot find function `listpids` in this scope --> external/rust/crates/libproc-rs/src/processes.rs:68:5 | 68 | listpids(filter) | ^^^^^^^^ not found in this scope | help: consider importing this function...

idersan

Use redoxer tool to test while running on linux

andrewdavidmackenzie

Will include fix to docs link, changes to rust minimal versions, fixing of ignored tests etc - but no real functionality changes

andrewdavidmackenzie

PIDRUsage and PIDFDInfo should be marked unsafe

8

First of all, thanks for the crate! It's really nice to have these sorts of foundational cross platform crates do the portability for you. I beleive the two public traits...

ethanpailes

fix: mark PIDFDInfo and PIDRUsage unsafe

3

This patch marks the PIDRUsage and PIDFDInfo traits as unsafe, since incorrect implementations of these traits could lead to unsound behavior. Unfortunately, since these are public traits, this will mean...

ethanpailes

Run grcov . --binary-path target/debug/ -s . -t lcov --branch --ignore-not-existing --ignore "/*" -o coverage.info || true Error: 5 [ERROR] A panic occurred at /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/grcov-0.10.0/src/llvm_tools.rs:95: called `Result::unwrap()` on an `Err`...

andrewdavidmackenzie