libproc-rs icon indicating copy to clipboard operation
libproc-rs copied to clipboard

fix: mark PIDFDInfo and PIDRUsage unsafe

Open ethanpailes opened this issue 1 year ago • 3 comments

This patch marks the PIDRUsage and PIDFDInfo traits as unsafe, since incorrect implementations of these traits could lead to unsound behavior.

Unfortunately, since these are public traits, this will mean an incompatible version bump for the next release, though hopefully no one is really rolling their own implementation for these guys.

https://doc.rust-lang.org/reference/unsafe-keyword.html#unsafe-traits-unsafe-trait

ethanpailes avatar Jul 15 '24 15:07 ethanpailes

Clippy fails due to missing docs for UNSAFE

andrewdavidmackenzie avatar Jul 23 '24 07:07 andrewdavidmackenzie

Fixes #146 I understand?

andrewdavidmackenzie avatar Jul 23 '24 07:07 andrewdavidmackenzie

The test failures should be fixed now. Sorry it took a minute, I had notifications routing to the wrong email.

ethanpailes avatar Jul 29 '24 12:07 ethanpailes