Reworked some bits

[0xAF]

Please take a look at this reworked code. I've made some simple changes and one bigger change to use more bash internals, instead of external tools. I've made most of the changes in separate commits, so you can easily see the changes.

[andrewchambers]

Overall these are good changes, though I won't merge for a few reasons.

1.) I prefer to keep sh instead of bash for portability reasons. 2.) Some things are specific to my setup, and this repo is mainly meant as an example, so handling so many edge cases is unnecessary.

However I think if we leave the pull request open for now, people will be able to see your patches and take those as an example to merge into their own fork if they want them.

[0xAF]

Thanks for the input. Sounds reasonable. I will keep my fork and probably make few more additions. Thanks for the idea in first place.

As for the bash, I think, probably all desktop distributions are having it installed, because some/many of the desktop apps are going to need it. And today's bash is >= bash-4.2 everywhere, which is a requirement for the matching stuff.

[andrewchambers]

Yeah, I often use OpenBSD which does have bash, but it is not installed by default.

[0xAF]

BTW, have a look at this commit you probably want to fix it in your code too... it allows for matching files with numbers in their names.

and may be this commit, which is information on how to add global shortcut in KDE.

[andrewchambers]

oh definitely, thank you very much, I'll try to cherry pick them.