bupstash icon indicating copy to clipboard operation
bupstash copied to clipboard

Published 20 hours ago • verified publisher icon andrewchambers

Fixes and improvements

Open piegamesde opened this issue 2 years ago • 6 comments

Closes #378

piegamesde avatar Apr 17 '23 08:04 piegamesde

The CI failures don't look like they were introduced by this PR

piegamesde avatar Apr 17 '23 09:04 piegamesde

Looks good, thanks for tracking this down, must have been a nightmare.

andrewchambers avatar Apr 17 '23 10:04 andrewchambers

Yeah, it was tedious and unpleasant in a lot of ways. Maybe the worst part was learning about how Linux IO works on a low level and how fundamentally broken it actually is.

About the second commit with the error messages, it is far from complete (it mainly contains a few sprinkled annotations that were required for me to track down the bug). I suggest merging it as-is, and strongly encouraging adding more context statements as we go over time.

piegamesde avatar Apr 17 '23 11:04 piegamesde

Oh, one more thing: I just read that error messages like these should be all lowercase, I'll fix that

piegamesde avatar Apr 18 '23 09:04 piegamesde

friendly ping

piegamesde avatar Apr 28 '23 14:04 piegamesde

@andrewchambers Any chance you could take a look another look at this?

jtrees avatar Dec 25 '23 22:12 jtrees