bupstash icon indicating copy to clipboard operation
bupstash copied to clipboard

Paths broken when adding multiple subdirs of /

Open tlotze opened this issue 3 years ago • 4 comments

When I put multiple directories with the same call, they will be stored as subdirectories of the common parent. However, when I do this with different subdirectories of the filesystem root, such as # bupstash put /etc /home, the paths will be broken:

# bupstash list-contents
drwxr-xr-x -         2022/11/07 11:05:36 .
drwxr-xr-x -         2022/11/14 19:25:52 tc
drwxr-xr-x -         2022/02/08 09:41:19 ome
...

and bupstash get --pick will also refer to those mangled paths.

tlotze avatar Nov 14 '22 20:11 tlotze

Thanks for the report - it seems like this slipped through because the test suite can't test the root directory so easily.

andrewchambers avatar Nov 15 '22 03:11 andrewchambers

This has been fixed in master and will be in the next bug fix release.

andrewchambers avatar Nov 21 '22 09:11 andrewchambers

This has been fixed in master and will be in the next bug fix release.

This happens when testing #363 on top of 0.12.0, which is what I did through the official OpenBSD port/package, where tests failed unexpectedly.

This PR lacked a reference to the actual fix, so here it is: a73fd83dc9556d1172f73ead2258fb127e36bb56.

klemensn avatar Jan 01 '23 16:01 klemensn

I will try to do a release in the next week or so we can get this fix out.

andrewchambers avatar Jan 01 '23 21:01 andrewchambers