Andrew Baxter
Andrew Baxter
Just a note, I haven't managed to get tests running locally. I built this with nix, which I think _might_ run tests as part of the build. I tested it...
Oh sure, and sorry about the DCO thing! I should re-read contributing more carefully...
Thanks for the review! And good point on the logs, I applied the suggestion. > Thank you for looking at this, it looks like the right approach - but there...
> So, some form of option 1 might be best ... I was thinking about this a bunch and I think for vlan parents we'd need 1 either way, so...
> The suggestion is just to make sure `CreatedSlaveLink` Right, that makes sense. > It's probably fine to squash the commits into a single one Ah sorry, I was intending...
Okay, I think I've taken care of everything: counting other users, integration tests. Notes on the use counting - I'm not sure if the `ok := ...; ok` is a...
Hey, just wanted to check in @thaJeztah @akerouanton to make sure you're not waiting on me. I'm still interested in getting this merged, I have current use cases where it...
Oh awesome, thanks so much!
Oh thanks! Sorry, I should have done that. I'm not sure if the ipvlan question was directed to me, my knowledge is pretty limited though. I'll try to read up...
Thanks again for helping me with this and the reviews!