Andrew Baxter
Andrew Baxter
Oh hey, I think I actually did implement this at some point: `keep_max_blank_lines` in the readme. If not I can investigate further, but closing for now.
Looks like maybe https://github.com/toml-rs/toml/issues/524 ?
I'm not sure if it's present until indexmap 1.9.2, or if it was a regression in 1.9.2 fixed in 1.9.3 or what. Maybe the autodetection is system dependent too? I...
Are you running in a container or something? I just tried with the `rust` container and didn't have any issues, although it used `Compiling indexmap v1.9.3` instead of 1.9.1 which...
I'm still trying to figure out what's going on here. AFAICT in https://github.com/bluss/indexmap/commit/99848fff179911f2573011dfc2859c182c9c0cfb indexmap stopped using autocfg for detecting std presence, and instead std is on by default. That's from...
Hmm, I do see autocfg showing up in the build ``` Compiling autocfg v1.1.0 ```
https://github.com/bluss/indexmap/blob/master/Cargo.toml doesn't include `autocfg` anywhere I can tell, but ``` $ cargo tree -i autocfg autocfg v1.1.0 [build-dependencies] └── indexmap v1.9.2 └── toml v0.5.10 └── cargo-manifest v0.7.1 └── genemichaels v0.1.21...
I forked cargo-manifest to bump toml which should set the indexmap flag... I think. Does adding ``` [patch.crates-io] cargo-manifest = { git = "https://github.com/andrewbaxter/fork-cargo-manifest", rev = "1957fc45baa9b16f894ffcbaecbd8289a026d2a9" } ``` to...
Here's my best guess as to what's happening, and I think updating the toml dep should fix it: https://github.com/toml-rs/toml/issues/539#issuecomment-1494339641 If that works for you, I'll make an MR for cargo-manifest.
Oh excellent! Yeah, I can't help there I think, but my best guess is it's how `autocfg` checks for std library presence, maybe to do with how files are stored...