Andrew Fleming

Results 29 comments of Andrew Fleming

No arguments from me—I agree with using the **describing the issue** approach and keeping the error messages consistent. If this is accepted, I'd suggest that we be mindful to try...

- Write the casing name in the casing style e.g. camelCase, snake_case, PascalCase, etc

- Write all non-H1 headings in sentence case (only capitalize the first word and proper nouns) - For the record, I disagree with this approach. I instead vote for title...

>> Write all non-H1 headings in sentence case (only capitalize the first word and proper nouns) >> - For the record, I disagree with this approach. I instead vote for...

This is _much_ better! I'm wondering if it makes sense to set `account` as a subdirectory (maybe inside `commands`?). That way, we can separate commands like `compile` and `node` from...

Here's a rough contract mod layout guide. ---- A. Outer contract elements 1. SPDX 2. `OpenZeppelin Contracts for Cairo v0.0.0 (path/to/file.cairo)` 3. Import statements for elements outside of the contract...

Contracts should order component impls, storage, and events in the same order that they're imported ``` #[starknet::contract] mod MyContract { use openzeppelin::introspection::src5::SRC5Component; use openzeppelin::token::erc721::ERC721Component; use starknet::ContractAddress; component!(path: SRC5Component, storage: src5,...

Also, tackling this issue should include adding `deploy_account` to Nile's documentation of the Account API (following the merge of #334)

Yes, the issue came from handling the class hash in `declare` and not removing the hex conversion in `register_class_hash` (#257). The issue should be fixed in `main` from the #122...