Andreu Botella

Results 114 comments of Andreu Botella
trafficstars

> Just to check: This problem only applies to `StringLiteral`s, right? Identifiers can also contain `\u` escapes. Can they be invalid too? Making `StringLiteral::value` a `&[u16]` (or something) I think...

> In [#9918](https://github.com/oxc-project/oxc/pull/9918), I made the following changes: > > In `StringLiteral`, added the `lossy` field to indicate whether the `value` contains a lossy replacement character (U+FFFD). > > In...

> Oh sorry, forgot to mention that we now have a `raw` field, or you can slice it from the source text. Oh, my bad! In that case, I think...

I suspect that this API might be used to determine the length of the buffer to use for `encodeInto()`, which it is not a good fit for, since it would...