laravel-analytics icon indicating copy to clipboard operation
laravel-analytics copied to clipboard

Add support for ignoring columns in the database

Open grantholle opened this issue 1 year ago • 5 comments

This adds support to ignore some columns when saving the page view record, i.e. ignoring the host column since I have a single tenant app and don't need it to bloat the table.

I also changed the test function names to get rid of the deprecation warning about metadata.

grantholle avatar Apr 18 '24 16:04 grantholle

Hey @grantholle, thanks for your PR. I'll try and take a proper look and test things out over the weekend.

Would you mind reverting the test names to keep the /** @test */ way of doing things rather than test_ please? Alternatively we could roll with the #[Test] attribute since I believe from the Laravel 11 requirements we can do that.

andreaselia avatar Apr 18 '24 18:04 andreaselia

I would going to use the #[Test] attribute, but then the package would have to drop support for php 7.4, as it's an 8.0 feature.

grantholle avatar Apr 18 '24 18:04 grantholle

We can drop support for PHP 7.4, that works for me and I imagine the majority of users of the package.

andreaselia avatar Apr 18 '24 20:04 andreaselia

Yeah I agree. Since v2.0.0 is already tagged and is php ^8.0, might as well just go with that major version. I think you can still support the older versions of Laravel, but just bump the php requirement.

grantholle avatar Apr 18 '24 22:04 grantholle

Ok @andreaselia, should be all set now

grantholle avatar Apr 26 '24 17:04 grantholle

Thanks @grantholle, apologies about the delay.

andreaselia avatar Jun 05 '24 18:06 andreaselia