Andreas Aeschlimann

Results 58 comments of Andreas Aeschlimann
trafficstars

My implementation adds a class `AbstractController` that has a static method called `register($app)`. This methods looks for attributes on the class that implements `AbstractController`. Attributes must be given to the...

Thank you for your input. We will look into it for sure and come back to you when we discussed it (it might take a while).

This is a very interesting idea, thank you. Will definitely consider this in an update. Any suggestion how we would achieve that? Probably with an additional setting on the jsonConvert...

I suggest that we introduce a new flag for serialization mode. When set, the serialization compares a given instance to a new instance and omits equal values. There is still...

The error message should be indeed improved. It cannot determine the expected type, but indeed we should fix this to show `CustomConverter` as expected type. I don't understand the logic...

Line 171 is correct actually. If you provide a custom converter, the expected type would be the one given in the methods of the converter. The problem is somewhere else:...

Thanks for the great input! Some of your commits were also suggested by the other pull requests, so I have integrated that already. I am still thinking about the reflection...

One of the great benefits for the real-world-use is for sure that you do not have to write "=undefined" for each property. And of course, with reflect-metadata the code of...

Have you thought about using a namespace for the class identifier? For example you could use `com.company.Classname` instead of `Classname` as identifier.

I also recommend to encourage the third-party dependency to use unique names for their class identifiers. If you have something more to add, feel free to reopen the issue.