Anders Kaseorg

Results 386 comments of Anders Kaseorg

Deprecating is not the same as removing—we still want to support the old syntax with a warning for some deprecation period. Also, this is not the only function affected by...

These all share the same antipattern: ```python def get_profile(self, request: Optional[Dict[str, Any]] = None) -> Dict[str, Any]: def update_presence(self, request: Dict[str, Any]) -> Dict[str, Any]: def get_users(self, request: Optional[Dict[str, Any]]...

A decorator might have the disadvantage of making the pydoc confusing and the mypy types poor (all mypy can guarantee about a decorator is basically “congratulations, you have *a function*!”)....

Not sure if I’ll have time for anything like a full review soon, but some quick thoughts: * An `async def` should not be annotated `-> Awaitable[…]`. The purpose of...

We could check if `package.json` has a `main` field starting with `dist/`; if so, pass `projectDir`, and if not, pass the old `path.join(projectDir, "dist/main/main.js")` for compatibility (and perhaps issue a...

Does the `chunkGroups` loop below also need to be sorted?

The upstream issue python-poetry/poetry#2789 was fixed, but the fix uses ephemeral build environments, and the information needed to reconstruct them is not recorded in the lock file. Perhaps another upstream...

Poetry 1.2.0a2 [generalizes](https://python-poetry.org/blog/announcing-poetry-1.2.0a2/#dependency-groups) the `dependencies` vs. `dev-dependencies` split to arbitrary groups (so you might have `prod`, `dev`, `test`, `docs`, for example). It’d be nice for poetry2nix to provide ways to...

5fd2425602b752576bbe8089c343d5d70ebc861c bumped many versions to 1.11.4 but left the corresponding dependencies stuck at 1.11.3. Some kind of Lerna accident?

Annoyance at Webpack is understandable, but I don’t think it had a better option. Using `pkg.module` for `import` and `pkg.main` for `require` could result in two independent copies of that...