Anders Kaseorg

Results 389 comments of Anders Kaseorg

It would be disallowed. If `foo` is really a string, I’d expect most people who write an invocation like that are expecting the behavior of `IMAGE_TEMPLATE.replace('{url}', () => foo)`. If...

I’m still slowly working on this. I have a rough plan for splitting the grammar that ought to work with LR(1) theoretically, but I took a detour to investigate what...

#8708 has been closed. Can this be un-deferred yet?

Here’s a complete, self-contained test case that depends only on electron and playwright-core. Works with [email protected], fails with 1.28.0 and 1.28.1. https://gist.github.com/andersk/96a04d05e1bd55c2754c514dd547d1e3 **`test.js`** ```js const { BrowserWindow, app, protocol }...

Slight correction: based on `git bisect`, this was actually broken earlier by - #18804

@dumblob In @catwell’s example `[link](foo_(bar_qux))`, the first closing paren is supposed to be part of the URL. Spaces don’t help. CommonMark has a [balanced parenthesis rule](https://spec.commonmark.org/0.30/#link-destination) to deal with this....

I came across this while debugging #325. I’m not aware of it showing up in a “real” application, but you know, it’d be nice to be sure it won’t.

> The resize observer should probably only start listening after initial setup.. The problem can be [triggered after initial setup](https://jsfiddle.net/anderskaseorg/4be5o91j/8/).

“settings_preferences: Fix implicit use of any” should not be a separate commit. See our documentation on [commit discipline](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html) (specifically: ‘If a commit you write doesn’t pass tests, you should usually...

I tested with `latest` which is `6.0.0-beta.2`. To be clear, you can still have a default export in `named` export mode, so `import SimpleBar from "simplebar"` would still work; it...