react-native-otp-entry icon indicating copy to clipboard operation
react-native-otp-entry copied to clipboard

Published 20 hours ago • verified publisher icon anday013

Focusing on fully filled input should have a focused affordance

Open rob-pathway opened this issue 1 year ago • 3 comments

When the OTP is fully filled and pressed (for editing), I think the input should show that it's focused somehow.

Proposal would be to focus (but persist) the last digit/character.

Thanks for this component!

rob-pathway avatar Apr 26 '24 18:04 rob-pathway

@rob-pathway Thank you for the proposal. I'll try to improve this aspect

anday013 avatar Apr 27 '24 10:04 anday013

Happy to submit a PR if you’d like!

rob-pathway avatar Apr 27 '24 15:04 rob-pathway

@rob-pathway sure!

anday013 avatar Apr 28 '24 09:04 anday013

@anday013 @rob-pathway just quick question, as I want to use this package. Will this PR be merged soon? :)

mrEuler avatar May 21 '24 19:05 mrEuler

@mrEuler @rob-pathway sry for delay. I'll make it available this week, thanks :)

anday013 avatar May 21 '24 20:05 anday013

Merged #56

anday013 avatar May 27 '24 08:05 anday013

@anday013 will test now, thank you man!

mrEuler avatar May 27 '24 09:05 mrEuler

@anday013 when could you publish new version?

mrEuler avatar May 27 '24 11:05 mrEuler

@mrEuler I want to merge the open PRs, and go for major release. I'll try to do it later today

anday013 avatar May 27 '24 13:05 anday013

@anday013 that would be awesome! Thanks again!

mrEuler avatar May 27 '24 17:05 mrEuler

@mrEuler A new version (1.7.0) is available with changes you need ✅ 🎉

anday013 avatar May 28 '24 07:05 anday013

@anday013 Thanks for adding tests. Looking good!

rob-pathway avatar May 30 '24 19:05 rob-pathway