Amyspark
Amyspark
@xclaesse How could I test the link flags of an executable? I thought (blindly) that Meson accepted per-language link flags, and I didn't find any other examples of checking link...
> hat way those libs will be used only if nasm is the linker which happens if there are no other languages in the same target This is required if...
I've just tested and with these changes under CLANG64 and UCRT64 flavors of MSYS: ``` The Meson build system Version: 0.64.1 Source dir: C:\Users\Amalia\Desktop\meson-nasm Build dir: C:\Users\Amalia\Desktop\meson-nasm\build Build type: native...
@xclaesse let me see first if I've nailed the test suite. Then I'll nitpick the implementation of `get_crt_link_args`.
@xclaesse [This error](https://dev.azure.com/jussi0947/jussi/_build/results?buildId=15983&view=logs&j=447df341-d5a1-5d0e-9651-c9f66402368a&t=12f22127-2cd1-5ea8-0ccb-9ba120a59cea&l=2841) looks like the MSVS integration wasn't tested. I'll try and see if I can fix it along with the rest.
@xclaesse I can't find any failed tests in the cygwin CI logs, even when grepping. Do you know what are those failures?
Fixed by #11405 and 744e6ebe1d5f214fd54727abde0726160218a1f0, I'll reopen if we need the remaining changes!
> this would have to emit a FeatureNew if you use it I've added, though not sure at all how those are used. Please tell me if I've put the...
@xclaesse I've reviewed this again and since there's been an improvement in documentation of `ExternalProgram.full_path()` I've clarified my case there. It's also easier to handle compared with the new typing...
@nirbheek ping for review, @tristan957 said you were knowledgeable in this area.