amundsen icon indicating copy to clipboard operation
amundsen copied to clipboard

ci: preview environments for every PR using Uffizzi

Open waveywaves opened this issue 2 years ago • 14 comments
trafficstars

Summary of Changes

Add github workflow which builds the amundsend metadata, search and frontend images from the PR branch and uses them to create a preview environment on Uffizzi.

A PoC of this PR has been done here After this PR is merged, all the subsequent PRs to this repo will have preview environments deployed with a link to the preview posted to the PR like this The preview created in the above PR can be accessed here https://app.uffizzi.com/github.com/waveywaves/amundsen/pull/1

fixes https://github.com/amundsen-io/amundsen/issues/2040

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • [x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • [x] PR includes a summary of changes.
  • [ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • [ ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

waveywaves avatar Dec 08 '22 21:12 waveywaves

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

boring-cyborg[bot] avatar Dec 08 '22 21:12 boring-cyborg[bot]

cc @Golodhros

waveywaves avatar Dec 08 '22 21:12 waveywaves

What do you think of this @feng-tao and @verdan ?

It works, although we should tweak our docker stuff to have some test data in order for it to be useful

Golodhros avatar Dec 09 '22 16:12 Golodhros

Hi @waveywaves, thank you for integrating this! In terms of the question of test data, I know the Quick Start steps outline how to include some sample data - would it be possible to include the same here?

kristenarmes avatar Dec 09 '22 20:12 kristenarmes

I don't have any context on the use case or the product. So need to defer to others to review

feng-tao avatar Dec 10 '22 00:12 feng-tao

I don't have any context on the use case or the product. So need to defer to others to review

This allows us to have a private URL where we see the changes introduced by a PR in real live!

Golodhros avatar Dec 12 '22 18:12 Golodhros

This allows us to have a private URL where we see the changes introduced by a PR in real live!

@Golodhros It will be a public URL :) You can show off your new features in team meetings and also share the preview with customers who would want a certain feature/bug, implemented/fixed.

waveywaves avatar Dec 12 '22 20:12 waveywaves

@kristenarmes Thank you for the tip. I have created a dockerfile which will help us build the databuilder-init image which we can use to initialize the db with some data. Although, I am facing a problem during it's build. Getting a Could not import runpy module during it's build. Here is the build for context.

waveywaves avatar Dec 12 '22 20:12 waveywaves

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 31 '22 19:12 stale[bot]

Happy New year team ! @Golodhros let me know if these changes make sense. And let me know if this works for you.

https://github.com/amundsen-io/amundsen/pull/2051#issuecomment-1347242357 how can I solve this problem

waveywaves avatar Jan 03 '23 14:01 waveywaves

Hi @Golodhros - friendly ping. I discussed this with @waveywaves and just wanted to check in and see if Preview Environments for every PR is something you want. If not we can close out the PR

jpthurman avatar Jan 24 '23 11:01 jpthurman

Hi @Golodhros - friendly ping. I discussed this with @waveywaves and just wanted to check in and see if Preview Environments for every PR is something you want. If not we can close out the PR

Hi @jpthurman, this is definitely something we want to have!

The problem is that the team at Lyft is really busy these days and I don't have the skills to help you solve that issue. I will keep on pinging other maintainers to see if they can help!

Thanks for your patience!

Golodhros avatar Jan 24 '23 18:01 Golodhros

Thanks for the reply @Golodhros

I think this can be solved in a short zoom call. Can you set up a time with right person within Lyft? Cc @waveywaves

jpthurman avatar Jan 24 '23 18:01 jpthurman

Thanks for the reply @Golodhros

I think this can be solved in a short zoom call. Can you set up a time with right person within Lyft? Cc @waveywaves

Makes sense! Give me some days to figure it out though, we have an upcoming internal presentation that the team is focused on these days!

Golodhros avatar Jan 24 '23 18:01 Golodhros