amphtml icon indicating copy to clipboard operation
amphtml copied to clipboard

Adding support to amp-ad for vadserver network

Open satrolkqd opened this issue 6 years ago • 5 comments

Implemented in amp-ad support for vadserver with lkqd player.

satrolkqd avatar Aug 27 '19 15:08 satrolkqd

I check the required error in travis, but when I enter in details, I see something about an apt-get install issue. I have some doubts if it can be related to my code, but I want to confirm if possible, please.

Thanks a lot

satrolkqd avatar Aug 28 '19 08:08 satrolkqd

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Sep 09 '19 14:09 googlebot

@satrolkqd Looks like the apt get issue sorted itself out. Could you please try to resolve the CLA issue? Let me know if you get stuck. Thanks!

calebcordry avatar Sep 18 '19 18:09 calebcordry

@satrolkqd is this PR still active?

/cc @ampproject/wg-ads

mrjoro avatar Jun 11 '20 17:06 mrjoro

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Mario
:x: satrolkqd


Mario seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 26 '21 03:01 CLAassistant

Closing for being inactive.

powerivq avatar Sep 06 '24 11:09 powerivq