serverless-domain-manager icon indicating copy to clipboard operation
serverless-domain-manager copied to clipboard

Does serverless domain manager work with serverless framework 4?

Open funkel1989 opened this issue 1 year ago • 1 comments

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description Unable to use serverless-domain-manager with serverless framework 4. Issue when trying to NPM install

Command Run npm install serverless-domain-manager --save-dev

Console Output

npm install serverless-domain-manager --save-dev
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/serverless
npm error   dev serverless@"^4.0.35" from the root project
npm error
npm error Could not resolve dependency:
npm error peer serverless@"^2.60 || ^3.0.0" from [email protected]
npm error node_modules/serverless-domain-manager
npm error   dev serverless-domain-manager@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error

Domain Manager Configuration Not even configured yet

Versions

  • Domain Manager version(s): latest
  • Node/npm version: 20
  • Serverless Version: 4.0.36
  • Lambda Code: Dotnet8

funkel1989 avatar Jun 08 '24 21:06 funkel1989

Looks like this is a simple fix. We'll provide a PR.

austencollins avatar Jun 18 '24 18:06 austencollins

Hey @rddimon , any chance for a release with this merged now? (sorry, commented on the PR as well)

cbschuld avatar Aug 07 '24 22:08 cbschuld

We have the same issue when we try to use sls version 4 with domain manager, do you have any fix of this?

franrivero avatar Aug 27 '24 19:08 franrivero