Andreas Motl

Results 1502 comments of Andreas Motl

Hi again, we have another PR which demonstrates how distractive the current implementation of CodeQL admonitions is: https://github.com/crate/crate-python/pull/498. The admonitions dominate the whole page and there is no chance to...

Hi again, at [1], there is another spot which I would like to draw your attention to. The first few admonitions are actually items which already have been _fixed_, contrary...

Hi, another spot at [2] has been fixed with a subsequent push, but the admonition is still there. Following "Show more details" yields a 404 at [3]. With kind regards,...

Thank you very much for discovering this on our CI configuration 🌻, I am just fixing it with https://github.com/crate/crate-python/pull/505 based on your suggestions. Apologies for not reading the documentation properly...

Hi again, I think all the teething woes are gone with the @github-code-scanning bot improvements you have been bringing in at the beginning of the year. Thank you again for...

Hi Chris. Thanks for the kind words. Yet, I can't promise anything. So, what would be the procedure you are asking for? Checkout the branch, invoke the tests, and make...

Hi Chris. Unfortunately, I am not running Linux. So, I think I can't be supportive here. Apologies.

> Testing is close to working now and @amotl is a genius with the mocker calls as he re-factored my whole test suite a little over a year ago. Hopefully...

It looks like there is a mixup of NotifyMSTeams vs. NotifyMatrix here. It happened on PyPy 3.9 with #694. ```python ________________________ test_plugin_msteams_templating ________________________ [...] > assert mock_post.call_args_list[0][0][0].startswith( 'https://outlook.office.com/webhook/') E AssertionError:...

Hi Chris, thanks for your response. The error reported above was only a fluke on CI, it is not deterministically reproducable right now, neither individually nor in combination. I also...