Ashok Menon
Ashok Menon
> I do not follow why this is better at the endpoints than in the query limits logic checker. My thinking was that if you do the query payload check...
Thanks for looking into this @stefan-mysten -- echoing our conversation elsewhere: Using `Content-Length` is a great idea -- and doing that by adding middleware to capture the content length, but...
Ended up making quite a few changes/refactors. Detailed in the commit message from me, but I'll copy it here for reference: - Move the overall (initial) payload size check to...
> The additional tests are to come, still. Tests now added, this PR should be good to go now.
@emmazzz this should still be relevant, right?
I think the performance concerns are interesting and worth digging into. Re: `dryRun` vs `devInspect`, the main thing for me is what Jordan mentioned above -- GraphQL implements `dryRunTransactionBlock` via...
> My first reaction to this news is that we have done a very mean thing to our GraphQL users, but I would be interested in learning more (especially with...
Yeah, I don't think we have tests that would expose exactly this kind of dry-run vs dev-inspect strangeness in GraphQL (Today it's a little tough to write GraphQL transactional tests...
@tpham-mysten ended up introducing a builder pattern which means we no longer need to go down this route!
I decided to do a clean room implementation of the core serialisation/deserialisation logic, using serde's `Serialize` and `DeserializeSeed`. Here it is: https://gist.github.com/amnn/cb02dfd0a6cd53fd64fe108669d1bbee It's very similar to what you have here,...