Android-Debug-Database icon indicating copy to clipboard operation
Android-Debug-Database copied to clipboard

Add consumer Proguard rules

Open MiSikora opened this issue 5 years ago • 4 comments
trafficstars

Library should provide consumer Proguard rules. Our QA builds are shrinked but still use utilities such as this one. I didn't pinpoint which rules are required specifically and just use -keep class com.amitshekhar.** { *; } as the library never touches release builds. Without these rules inspection tool can only see the shape of the database but not its content.

Is it something that you would consider adding into the library? If so, are these broad rules fine or do you think something more specific should be provided?

MiSikora avatar Nov 26 '19 15:11 MiSikora

Please use this

 -keep class com.amitshekhar.DebugDB**
 -keep class com.amitshekhar.model.** { *; }

amitshekhariitbhu avatar Nov 26 '19 16:11 amitshekhariitbhu

Cool, thanks!

Still, do you think it is something that might be embedded into the library or do you want to keep rules out of it?

MiSikora avatar Nov 26 '19 16:11 MiSikora

Rules can be added as consumer proguard files: https://google.github.io/android-gradle-dsl/current/com.android.build.gradle.internal.dsl.BuildType.html#com.android.build.gradle.internal.dsl.BuildType:consumerProguardFiles

koral-- avatar Nov 26 '19 17:11 koral--

@MiSikora We will add this to the library in the consumer Proguard rules in the new release.

amitshekhariitbhu avatar Nov 27 '19 04:11 amitshekhariitbhu