fastapi-user-auth icon indicating copy to clipboard operation
fastapi-user-auth copied to clipboard

Postgres fix + English localization

Open MatsiukMykola opened this issue 2 years ago • 5 comments
trafficstars

This PR fixes Postgres compatibility (SQLite does not work now, this is in progress). Translated to English strings (my native - Ukraine language Ukrainian Flag, so there can be typos) and prepared to use with i18n (in progress).

Work in progress. PR - you are welcome!

MatsiukMykola avatar Oct 18 '23 12:10 MatsiukMykola

Thank you very much for your work and I will complete the merger as soon as possible

amisadmin avatar Oct 19 '23 06:10 amisadmin

@amisadmin any update on this?

hsluoyz avatar Jan 11 '24 01:01 hsluoyz

Hello, this commit has not been merged, mainly because some of the changes are for Postgres, but at present I use mysql here and sqllite in the test environment, and I hope to find an implementation that is perfectly compatible with these three.

amisadmin avatar Jan 12 '24 01:01 amisadmin

@MatsiukMykola hi, can you split this into two PRs? One for English i18n and another for Postgres fix. I think everybody would be OK for the i18n change at least.

hsluoyz avatar Jan 12 '24 02:01 hsluoyz

@MatsiukMykola hi, can you split this into two PRs? One for English i18n and another for Postgres fix. I think everybody would be OK for the i18n change at least.

under air alarm every day this can be a little "difficult"

MatsiukMykola avatar Jan 12 '24 06:01 MatsiukMykola