Amir Ziai

Results 28 comments of Amir Ziai

thanks for the PR @kanelee7512. do you mind adding your examples to the tests? i will reviewer later this week.

@mcarans let's say we have this dictionary (feel free to come up with a better example but I want us to nail down the requirements): ``` d = { 'a':...

If it's root-level and the argument you pass is the set to be filtered I think I've addressed it in #11 . Here's the documentation I wrote: https://github.com/amirziai/flatten/tree/flatten-ignore-keys%239#ignore-root-keys Am I...

@mcarans I think I understand now. The point of `flatten` to me is that the resulting object has no structure (no iterables other than strings are present as values of...

thanks for the PR @sudor , do you mind writing a test to show the intended behavior?

do you have the latest version of `flatten_json`? try upgrading and try again ``` pip install --upgrade flatten_json ``` i'm get this output with your example: ``` {'seo': {'test': 'hello'}}...

thanks @zechengz . i see, looks like `snapx` comes as a part of `snap` which is the pypi package `snap-stanford`? what do you think about this: ``` GraphType = Union[nx.Graph,...

@zechengz lmk if you like the suggestion above, otherwise i can drop the type params and we can merge this. thanks!

thanks @zechengz , just made the change. lmk if you have any other feedback i should consider.