Attila Szeremi

Results 64 comments of Attila Szeremi

@derrabus I understand the need to be as fast as possible. As an alternative, I could instead implement this by allowing to override the supported types via constructor option, as...

@stof Literally my first implementation was changing the `supportsDenormalization()` method's behavior to iterate the `SUPPORTED_TYPES` constant's types and do additional `is_subclass_of()` checks against the passed `$type`, but @derrabus told me...

@derrabus, ok, then I'll change the behavior to make the list of supported classes configurable in the constructor, but use a separate property from the context's to store/read them.

@derrabus Done. Note that I made the `DEFAULT_SUPPORTED_TYPES` const public so that you could easily do an `array_replace()``/array_merge()` with the default supported types when overriding them in the constructor.

@stof you need to come to some agreement with @derrabus, because he didn't like it when I wrote it to the way you are suggesting. The only difference was that...

Alright, I've added the simplified `is_a()` check that was mentioned. Note that maybe `getSupportedTypes()` should also just return [DateTimeInterface::class] without the (built-in) subclasses redundantly? And then maybe we could do...

@stof what do you mean? here are the square brackets. ![image](https://github.com/user-attachments/assets/86064e28-83ae-463f-beb6-ba12ae19d83c)