amazon-archives
Use external model references instead of inlining
This pull request addresses issue #43. Instead of inlining all model definitions, we use external references now. This way we are reusing models which reduces the amount of classes and code generated in SDKs.
My main concern about this pull request: This code effectively removes inlining. Is there any case in which inlining would be preferred over external references?
Is there any news on this? For us it works, but is there any shortcoming as @arabold mentioned?
This solution isn't working for me. The code works perfectly but API Gateway does not like "https://apigateway.amazonaws.com/restapis/APP_ID/models/User" even though there is a 'User' model on "APP_ID". Is this still working for you guys?
It was still working perfectly fine last week. We're making heavy use of models and external references. When is it giving an error and what's the specific message?
Since API Gateway validates the existence of references in your model schemas, the models must be imported in the correct order from the "leaf" nodes upwards. The import will fail if the importer attempts to create a model before its dependent reference model is imported.
This is most likely why this is failing for @KraigM.
I will merge this if you can update so that the models are guaranteed to be imported in the correct order, and resolve conflicts.
