amazon-cognito-auth-js icon indicating copy to clipboard operation
amazon-cognito-auth-js copied to clipboard

AdvancedSecurityDataCollectionFlag is always true

Open grmoon opened this issue 6 years ago • 0 comments

In lines 74-77 of CognitoAuth.js advancedSecurityDataCollectionFlag is set. This property is a boolean, however it can only ever be set to true due to the conditional before it is set from the AdvancedSecurityDataCollectionFlag passed to the constructor.

this.advancedSecurityDataCollectionFlag = true;
if (AdvancedSecurityDataCollectionFlag) {
    this.advancedSecurityDataCollectionFlag = AdvancedSecurityDataCollectionFlag;
}

These lines should really just be

this.advancedSecurityDataCollectionFlag = Boolean(AdvancedSecurityDataCollectionFlag);

grmoon avatar Dec 24 '18 16:12 grmoon