egui-phosphor icon indicating copy to clipboard operation
egui-phosphor copied to clipboard

Icons in thin module are misplaced

Open aspect opened this issue 2 years ago • 2 comments

It appears that ranges of icons in (at least) the thin module are misplaced in an "off by one" fashion.

If you use LIST you get LIST_PLUS and this affects others, but they seem to be in ranges, as CLOUD_X is fine. However all LIST_XXX are affected, CHECK_XXX and there are a bunch more, unfortunately, I can't tell which ranges right now. The shift seems to be specific to thin module but I could be wrong. Perhaps making a small dump to examine or to re-examine the import process would help.

LMK if you need any help/feedback. I am extensively using this right now in an Egui project.

aspect avatar Dec 04 '23 21:12 aspect

Hi and thanks for raising this. I know this is super old and I'm sorry. Since the fonts got updated with 0.6.0, is this still relevant?

amPerl avatar Jul 30 '24 16:07 amPerl

I'll give this a try in the coming days and will report back.

aspect avatar Aug 09 '24 13:08 aspect

@amPerl Hi there, when checking out the latest version, egui-phosphor = "0.7", at least the CPU icon seems wrong. I expected this icon instead

image image

CtByte avatar Oct 09 '24 07:10 CtByte

thanks! looks like the built in egui fonts were taking priority here. could you update and check if 0.7.2 fixes it for you?

amPerl avatar Oct 09 '24 14:10 amPerl

@amPerl CPU is fixed in version 0.7.2. Thank you so much for the quick response!

In case you wanted a confirmation on the original issue, I also tested the LIST and LIST_PLUS icons and they are also correct.

CtByte avatar Oct 09 '24 20:10 CtByte

@CtByte does this still work with 0.7.3 for you?

bircni avatar Oct 11 '24 14:10 bircni

@bircni egui_phosphor::regular::CPU does seem to still work in 0.7.3 image

CtByte avatar Oct 11 '24 15:10 CtByte

so this can be closed?

bircni avatar Oct 13 '24 17:10 bircni

My issue is solved, so if you are asking me, it can be. I am grateful for the quick help!

CtByte avatar Oct 13 '24 19:10 CtByte