xarray-sql icon indicating copy to clipboard operation
xarray-sql copied to clipboard

Create a pre-commit config and set of rules for the project.

Open alxmrs opened this issue 2 weeks ago • 2 comments

https://pre-commit.com/

I'd like to automate our auto-formatter with pyink and type checking (say, via mypy) at the very least. To close this issue, let's document using this pre-commit rule in the contributing guide.

alxmrs avatar Nov 25 '25 04:11 alxmrs

what's your opinion on ruff instead of pyink ? Also please check https://github.com/alxmrs/xarray-sql/pull/91

jayendra-info avatar Nov 27 '25 04:11 jayendra-info

I am happy with either! When I started this project, I was more familiar with pyink than ruff, but these days I primarily use the former.

alxmrs avatar Nov 27 '25 05:11 alxmrs

Is this closed by #91? I see that usage is also documented in https://github.com/alxmrs/xarray-sql/blob/main/CONTRIBUTING.md

cisaacstern avatar Dec 03 '25 17:12 cisaacstern

That's right. Closed by #91. Thanks Charles.

alxmrs avatar Dec 03 '25 20:12 alxmrs