react-native-photo-view icon indicating copy to clipboard operation
react-native-photo-view copied to clipboard

UI Thread dropping frames on RN 0.51

Open jjdp opened this issue 7 years ago • 9 comments

The ui thread frame rate dips when trying to load an image from a remote source. It was working fine on 0.49.5. Haven't tested on 0.50 since i skipped this one.

It basically waits for an image to load so the ui thread hangs. Very noticeable with large pictures. Easily testable with setting props.source={{uri: ''}} there are no hang ups

jjdp avatar Dec 21 '17 16:12 jjdp

Can you check If the changes in #139 fix the problem for you?

LcTwisk avatar Dec 21 '17 17:12 LcTwisk

still the same

jjdp avatar Dec 22 '17 02:12 jjdp

I'm experiencing exactly the same issue. #139 actually made it worse for me.I am using react-native-router-flux modal to show PhotoView. Everything was fine till the upgrade of RN 0.51. Now it hangs half way of the modal animation. With #139 All modal animations are gone.

ergunyasar avatar Dec 25 '17 10:12 ergunyasar

Can confirm this problem as well.. Previously everything worked smoothly with RN 0.49. Did you guys now find a fix that works reliably?

wwwdata avatar Jan 12 '18 15:01 wwwdata

sadly no this lib seems unmaintained. I'm using pure JS for my use case atm.

jjdp avatar Jan 13 '18 08:01 jjdp

+1

cbjs avatar Jan 23 '18 06:01 cbjs

anyone can run it on RN 0.53.3?

image

musicode avatar Mar 09 '18 03:03 musicode

I also experience the same issue with "react-native": "0.55.4", "react-native-photo-view": "^1.5.2" and "react-navigation": "^2.5.5". Transition animation when navigating to a screen with PhotoView is very slow and stop at the middle. With #139 fixes, the screen actually stops before the transition happens.

wcyiu avatar Jul 05 '18 08:07 wcyiu

#139 does not help

tmjordan avatar Feb 05 '19 01:02 tmjordan