Line numbers overlap query pane

[febeling]

Describe the bug After the in-app update to 4.6.2 on macos 11.6.8, there's a visual bug. Also an error notification is shown for a moment.

To Reproduce Steps to reproduce the behavior: Just open the app and click and "Add new"

Expected behavior No overlap of code and line numbers.

Screenshots

Desktop (please complete the following information):

• OS: macOS 11.6.8
• Browser: n/a
• Platform: Electron app (download from website)
• Version: 4.6.2

Additional context Happens with existing query as well as new pane.

[imolorhe]

Do you also have this issue if you set enableExperimental to true in the settings?

[febeling]

@imolorhe Yes, it seems to behave correctly sometimes under experimental, and more often, but still is also sometimes broken.

[imolorhe]

If possible, could you share screenshots of it broken under experimental? I expect the editor under experimental to fix this issue completely so I'm surprised to hear that it's broken there as well

[code-is-art]

I also have this issue on altair-express-middleware. I will try enableExperimental to see if it helps. edit: seems to have helped. I will keep updating if it breaks with experimental on.

[febeling]

@imolorhe I can't reproduce the problem rn, with experimental enabled. I seem to remember to also experience with that setting, but now have doubts that I checked correctly.

[imolorhe]

Under experimental, we have a new editor (code mirror 6) for the query editor. The variables section still uses the old editor though, so maybe that's where you saw it?

[febeling]

@imolorhe no, I'm pretty certain I didn't work with vars, at that point.

Feel free to close, it still can be re-opened if more info emerges.

[imolorhe]

Closing this issue as it should be fixed in the new editor