pico-router icon indicating copy to clipboard operation
pico-router copied to clipboard

#62 use req.redirect and req.mount in svelte examples

Open acim opened this issue 5 years ago • 0 comments

Proposed changes

Svelte examples were broken because in main.js they used res.redirect and res.mount instead of req.redirect and req.mount

Types of changes

What types of changes does your code introduce to Crayon? Put an x in the boxes that apply

  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)

I tried to run "make test" but I got an error:

● Validation Error:

  Module ts-jest in the transform option was not found.
         <rootDir> is: /home/acim/Projects/public/crayon/src/kit

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

However, I tested manually in browser and there are no console errors like before.

acim avatar Aug 18 '20 22:08 acim