ghc.nix icon indicating copy to clipboard operation
ghc.nix copied to clipboard

Can we archive this repo?

Open doyougnu opened this issue 1 year ago • 17 comments

I'd like to archive this repo and use https://gitlab.haskell.org/ghc/ghc.nix instead. Thereby making the gitlab version the "main" version for development and patches.

Why? Several reasons:

  • The response time for this repo has lagged over time cc @MangoIV
  • This has made it hard for GHC devs to keep dependency versions in sync with what we run on GHC's CI.
  • As this is for ghc, I'd like to be able to point the GHC wiki and documents to a repo that is inside the GHC project on gitlab. cc @supersven

doyougnu avatar Apr 11 '24 11:04 doyougnu

For what it's worth this I also aimed to migrate this repo to GitLab in the past but was distracted before the job was finished. I would welcome this move.

bgamari avatar Apr 11 '24 11:04 bgamari

I was planning to do this. (Move to ghc gitlab, I already brought it up to date but have yet to set up a proper CI)

I would maintain this repo for the time being but I’m not maintainer for this repo.

MangoIV avatar Apr 11 '24 11:04 MangoIV

Sadly I think the CI here on GitHub has become useless as it cannot build GHC anymore (I think the container runs out of memory)

MangoIV avatar Apr 11 '24 11:04 MangoIV

I put up https://gitlab.haskell.org/ghc/ghc.nix/-/merge_requests/4 as a starting point for GitLab CI.

bgamari avatar Apr 11 '24 14:04 bgamari

See also !3 in the same repo…

MangoIV avatar Apr 11 '24 14:04 MangoIV

Ahh, very good. I'll close mine in that case.

bgamari avatar Apr 11 '24 14:04 bgamari

@bgamari do you think we should merge the PRs whose CI currently fail but are verified working before moving to the new repo?

MangoIV avatar Apr 12 '24 18:04 MangoIV

#186 #188 #189 (haven’t looked at #190 yet but perhaps also that one)

MangoIV avatar Apr 12 '24 18:04 MangoIV

I can reopen mine about modularization as that’s a bit more of an effort anyway and I wanna redo it properly at some point, as well

MangoIV avatar Apr 12 '24 18:04 MangoIV

IMHO we could switch to Gitlab. The main reason why ghc.nix is hosted on GitHub is likely because it started here at Phabricator times..

supersven avatar Apr 13 '24 07:04 supersven

do you think we should merge the PRs whose CI currently fail but are verified working before moving to the new repo?

I think we should just remake them on the new repo. Most of these are really trivial.

I'll take #188 #189 and #190, #188 and #190 are mine and #189 is just a matter of adding the packages.

But basically I'd rather just migrate now and clean up later.

doyougnu avatar Apr 16 '24 13:04 doyougnu

Arriving a bit after everything took place, but yes, I was also in favor of throwing this repo on gitlab early on but never really followed up.

alpmestan avatar Apr 19 '24 08:04 alpmestan

cc @bgamari @MangoIV

I've opened https://gitlab.haskell.org/ghc/ghc.nix/-/merge_requests/6 which migrates #188 #189 #190

doyougnu avatar Apr 19 '24 18:04 doyougnu

Thank you, I’ll leave a review but I think I’ll need a review on the CI PR by bgamari first (s.t. You can have CI on the PR)

MangoIV avatar Apr 19 '24 18:04 MangoIV

I think the migration is complete, no?

sgraf812 avatar Oct 21 '24 07:10 sgraf812

More or less. I think it would be neat to set up a mirror here on GitHub. But idk if this repo is the right place.

MangoIV avatar Oct 21 '24 07:10 MangoIV

I suppose a github mirror for ghc.nix would belong next to GHC's own github mirror.

alpmestan avatar Oct 21 '24 20:10 alpmestan