ember-scrollable icon indicating copy to clipboard operation
ember-scrollable copied to clipboard

Published 20 hours ago • verified publisher icon alphasights

jQuery dependency

Open richard-viney opened this issue 6 years ago • 5 comments

Hi,

Right now this addon needs Ember's jQuery integration to be enabled as it uses this.$() in several places, as well as some jQuery functions.

This could be refactored to avoid mandating a dependency on jQuery, though in the meantime adding the @ember/jquery package as an explicit dependency might be a good first step.

Thoughts?

richard-viney avatar Apr 15 '19 03:04 richard-viney

We just need to push this over the finish line https://github.com/alphasights/ember-scrollable/pull/98 I haven't been much help since I have a massive backlog of work and other prioritize right now, I apologize

alexander-alvarez avatar Apr 15 '19 14:04 alexander-alvarez

Ok no problem, is there a list of what remains to be done?

richard-viney avatar Apr 16 '19 09:04 richard-viney

Will also need to bump ember-element-resize-detector to 0.4.0 as the current dependency version also includes jquery.

fran-worley avatar May 10 '19 08:05 fran-worley

@alexander-alvarez as this is now causing many deprecation errors in ELT is there anything we can do to help push #98 over the finish line and get a version bump on this?

Alternatively we could do a simple refactor to fix the deprecation issues for now - happy to raise a PR for this if you think this will be quicker.

fran-worley avatar Aug 19 '19 12:08 fran-worley

+1 to @fran-worley. Getting rid of the deprecations by explicitly importing jQuery would be great for now

waissbluth avatar Oct 16 '19 17:10 waissbluth