ZenQ icon indicating copy to clipboard operation
ZenQ copied to clipboard

Should this be merged to Go core?

Open nikolaydubina opened this issue 3 years ago • 6 comments

If this is really fast and without downsides, should this be in Go core?

Maybe folks in go-dev google group will get interest.

nikolaydubina avatar May 03 '22 02:05 nikolaydubina

I don’t think so, although it looks fast on paper, one of the biggest advantages of go’s native channel is the ability to select across multiple channels and broadcast using the close function

shubhang93 avatar May 03 '22 03:05 shubhang93

Select, Close, Broadcast sounds like additional features, possibly implemented without deteriorating performance boost?

I am very curious what are the drawbacks of this approach. If there are no clear problems, this can be big thing like Ryu or more recent pdqsort.

I think we are standing on something big here.

nikolaydubina avatar May 03 '22 05:05 nikolaydubina

cc @alphadose

nikolaydubina avatar May 03 '22 05:05 nikolaydubina

I have already opened an issue for it https://github.com/golang/go/issues/52652

alphadose avatar May 03 '22 07:05 alphadose

We can gain even further optimizations by using runtime internal methods like gopark instead of spinning mechanism which is the current implementation thereby ensuring minimum required goroutine utilization without any performance drops

alphadose avatar May 03 '22 07:05 alphadose

Hope Go can really support this optimization. It's a certainly great project! However, as far as i'm concerned, those guys in Google wonld't hear from people from the community most of time. That's a little bit tragedy. :(

MeteorsLiu avatar May 05 '23 12:05 MeteorsLiu