layout
layout copied to clipboard
allpro
jQuery 3 compatibility issue
This line breaks jQuery 3 support, seems to work fine without it: https://github.com/allpro/layout/blob/master/source/stable/jquery.layout.js#L1832
Also .bind / .unbind are deprecated.
The container.selector property was provided only for information. It is never used by Layout so I'll just delete it.
I saw this issue in a forum post. I will be reviewing all the bugs I saw there soon, as well as the pull requests.
Thanks Kevin, it's great that you are back. I was worried that something had happened to you! On 3 Jul 2016 2:00 a.m., "Kevin Dalman" [email protected] wrote:
The container.selector property was provided only for information. It is never used by Layout so I'll just delete it.
I saw this issue in a forum post. I will be reviewing all the bugs I saw there soon, as well as the pull requests.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/allpro/layout/issues/10#issuecomment-230129491, or mute the thread https://github.com/notifications/unsubscribe/AAi_COzgaHnZEIF7e7w4BfagA0xBMwj9ks5qRwmpgaJpZM4JDuG9 .
Any word? We could be a little more backwards compatible perhaps something like sC.selector = $N.selector ? $N.selector.split(".slice")[0] : "";
Backwards compatibility makes sense, but I think undefined is better than an empty string so that it's clear this property is not available with jq3. This would break code that assumes a string value, but if the code relies on this property, it has to be updated anyway. This error would bring attention to the issue rather than create a hard-to-trace bug.
If users really need container object metadata, they can read it directly from layout.container (the jQuery object) instead of layout.state.container.
And the following line also breaks in jQuery 3 (please note, I've also have the jQuery migrate plugin installed): https://github.com/allpro/layout/blob/master/source/stable/jquery.layout.js#L2589
Any news on jQuery v3 compatibility?
I use @GedMarc fork of this project which he already implemented Jquery 3. https://github.com/GedMarc/layout
No haven't forgotten about you, +- 4 days I think till the new release.
V6 will change the responsive features into a more object orientated feel, and remove the new uniqueSort and binds() deprecation warnings. It also allows elements to be specified as contents for togglers instead of just pure html (with movement not copy). Specific width settings for responsiveness will also be available to allow for the changes in bootstrap4 regarding sizes.
Please note though that because of a dependency on JQuery UI, so some of these warnings will still pop up until they release a new update.
Is there any plan resolve this issue, or should I use the @GedMarc fork mentioned above?
Are you saying that this branch is not getting any future changes, and all changes are going to the fork? That is not documented anywhere that I have seen, which is why I am asking. Also, I am not able to create issues in the fork, that I can tell.
You should be able to create issues in the fork, But yes you are correct, no more change requests in the JQuery 2 Stable. The JQuery 3 Fork that I have is active and maintained, and is used in global libraries including PrimeFaces, WrapBootstrap and I do consider it stable under the assumption that over 14 million people are using it with no bugs logged in quite a long time. The latest change is to accommodate the new Z-Indexes in Bootstrap 4.1, Bootstrap 3 because of this may not show drop downs properly, but simply appending z-index:auto to the panel corrects this quite nicely.
Issue facing during the execution in electron app ...please help me to sort it out..
