create-wordpress-plugin icon indicating copy to clipboard operation
create-wordpress-plugin copied to clipboard

[BUG]: Phpstan config invalid if installed in larger project

Open kevinfodness opened this issue 2 years ago • 0 comments

Description of the bug

The phpstan config points to an include file in the vendor directory within the plugin, but if the plugin is installed as part of a larger project, the vendor directory is up a few levels (either ../../vendor, or ../../client-mu-plugins/vendor). This should be updated in phpstan.neon based on the user's preference of installing as part of a larger project and hoisting composer dependencies to the root.

Steps To Reproduce

  1. Install a new plugin based on this repo
  2. Say it's part of a larger project
  3. Choose the option to hoist composer dependencies to the root
  4. Add a script to the root config to run phpstan in the plugin's directory (e.g., cd plugins/my-cool-plugin && phpstan)
  5. Notice that the command fails with an error that it can't find the include file in the vendor path

Additional Information

No response

kevinfodness avatar May 05 '23 14:05 kevinfodness